-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add temporal replay protection #1681
Conversation
It may make sense to have a look at #599, which seems to be similar, and has some discussions. |
Oh thanks @axic , I vaguely recalled there being something like it already, but didn't find it. It differs a bit, though, since this one uses timestamp instead of block numbers, to make it more 'sane' from the perspective of an offline signer. I'll add it as a reference though. |
I've added a reference to the EIP by @Arachnid now, and also some more rationale about why this EIP uses utc time instead of blocknumbers. |
We should include that the address of a contract created by an EOA in a transaction with replay protection depends on the valid-until date in addition to depending on the nonce so that once dust account removal starts, contracts cannot be redeployed at the same address after being self destructed. |
Can we make this EIP more user-friendly? 'temporal replay protection' sounds a lot more complicated, and it sounds like it is security related similar to the replay protection EIP, vs. 'transaction deadlines' which is just a badly needed UX feature I ask because I want to bring this up in the next core developer call Also I prefer the word |
This PR adds an EIP about temporal replay protection, basically
valid-until
in the form of a timestamp to transactions.